Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nathelper: initialize local variable #1661

Merged
merged 2 commits into from Oct 1, 2018
Merged

nathelper: initialize local variable #1661

merged 2 commits into from Oct 1, 2018

Conversation

lazedo
Copy link
Contributor

@lazedo lazedo commented Oct 1, 2018

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

previous PR #1655 was wrong and tests at the time didn't hit the correct path in the code, sorry for that.
this pr reverts #1655 and properly initializes a variable

@miconda
Copy link
Member

miconda commented Oct 1, 2018

You can merge and backport when appropriate.

@lazedo lazedo merged commit c814f9f into master Oct 1, 2018
@lazedo lazedo deleted the lazedo/nathelper-fix branch October 1, 2018 15:13
@lazedo
Copy link
Contributor Author

lazedo commented Oct 1, 2018

@miconda thanks. is commit 0d14ce8 being backported ? or should i resolve the conflicts for 5.1 ?
i can backport it as part of this if you want

@miconda
Copy link
Member

miconda commented Oct 1, 2018

Backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants