Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdb: fix SIGABRT in case of too long uris #1693

Merged
merged 1 commit into from Oct 30, 2018

Conversation

lbalaceanu
Copy link
Contributor

buf in pdb_msg_dbg should correctly accomodate for pdb_bdy size
pdb_hdr + pdb_bdy should add to pdb_hdr.length (max 255)

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • [x ] Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • [x ] PR should be backported to stable branches
  • [x ] Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

Can I also port this back to 4.4? Thank you.

buf in pdb_msg_dbg should correctly accomodate for pdb_bdy size
pdb_hdr + pdb_bdy should add to pdb_hdr.length (max 255)
@miconda
Copy link
Member

miconda commented Oct 29, 2018

It can be merged and back ported to stable branches.

There is no restriction to back port to older branches, so you can push it to 4.4 as well -- the last two stable branches (now 5.0 and 5.1) are officially maintained from the perspective of doing releases out of them and it is not a must to backport. But if a developer wants to push to older versions, it is ok.

@lbalaceanu lbalaceanu merged commit e29c90c into kamailio:master Oct 30, 2018
@lbalaceanu
Copy link
Contributor Author

Thank you.

@lbalaceanu lbalaceanu deleted the pdb_fixabrt branch October 30, 2018 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants