pkg/kamailio/deb: optimize systemd units #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you please follow the commit guidelines using |
Units that strictly require a configured network connection should pull in network-online.target (via a Wants= type dependency) and order themselves after it. This target unit is intended to pull in a service that delays further execution until the network is sufficiently set up. What precisely this requires is left to the implementation of the network managing service. https://www.freedesktop.org/software/systemd/man/systemd.special.html https://lists.kamailio.org/pipermail/sr-users/2018-November/103668.html Signed-off-by: Kevin Olbrich <ko@sv01.de>
New: If set to on-failure, the service will be restarted when the process exits with a non-zero exit code, is terminated by a signal (including on core dump, but excluding the aforementioned four signals), when an operation (such as service reload) times out, and when the configured watchdog timeout is triggered. Old: If set to on-abort, the service will be restarted only if the service process exits due to an uncaught signal not specified as a clean exit status. https://www.freedesktop.org/software/systemd/man/systemd.service.html Signed-off-by: Kevin Olbrich <ko@sv01.de>
kevin-olbrich
changed the title
|
I have now force-pushed the changes and removed the ol/el7 service file from the changes. |
|
@kevin-olbrich push those changes with the proper prefix |
Units that strictly require a configured network connection should pull in network-online.target (via a Wants= type dependency) and order themselves after it. This target unit is intended to pull in a service that delays further execution until the network is sufficiently set up. What precisely this requires is left to the implementation of the network managing service. https://www.freedesktop.org/software/systemd/man/systemd.special.html https://lists.kamailio.org/pipermail/sr-users/2018-November/103668.html Signed-off-by: Kevin Olbrich <ko@sv01.de>
Done |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
in
doc/subfolder, the README file is autogenerated)Type Of Change
Checklist:
Description
Please see conversation on ML for reference:
https://lists.kamailio.org/pipermail/sr-users/2018-November/103668.html