Implement load and restore of contact attributes #178
Conversation
- Note that tm xavp_contact parameter must match
- Add xavp_contact parameter for name of xavp holding attributes from usrloc - t_load_contacts: Load per branch attributes into contact XAVP - t_next_contacts/t_next_contact_flow: Restore branch attributes
que273
changed the title
|
Does anyone have any comments on my fix? |
|
Hugh Waite writes:
Does anyone have any comments on my fix?
Can I merge and backport?
I think I implemented those tm functions. Does your fix require any
config file changes to the present use of those functions? If not, I
have nothing against them.
…-- Juha
|
|
The tm module needs to know the name of the attributes AVP, which is currently passed as a modparam to the usrloc module. Therefore to 'activate' this bugfix, you need to pass the same modparam to the tm module.E.g. |
|
Hugh Waite writes:
The tm module needs to know the name of the attributes AVP, which is
currently passed as a modparam to the usrloc module. Therefore to
'activate' this bugfix, you need to pass the same modparam to the tm
module.E.g.
`modparam("usrloc|tm", "xavp_contact", "ulattrs")`
If the modparam is not given to tm, the system will behave as before.
There are no changes to the way the functions are called.
What happened to the fix? Did it go to 4.3?
…-- Juha
|
|
No, is not in 4.3 --- actually, this pull request is not even merged in master. As I see the comments above, the discussion was still open. From my point of view, it can be merged and backported if it is a fix. |
Implement load and restore of contact attributes
|
Hugh Waite writes:
The tm module needs to know the name of the attributes AVP, which is
currently passed as a modparam to the usrloc module. Therefore to
'activate' this bugfix, you need to pass the same modparam to the tm
module.E.g. `modparam("usrloc|tm", "xavp_contact", "ulattrs")`
If the modparam is not given to tm, the system will behave as before.
There are no changes to the way the functions are called.
i'm still confused about xavp_contact tm module parameter. when i
implemented t_load_contacts(), t_next_contacts() and
t_next_contact_flows() functions, contacts_avp and contact_flows_avp
defined the xavps that those functions used as described in tm README on
those functions.
now there is another variable xavp_contact. tm README tells about it
that it is used for storing attributes per contact, but does tell how
the xavp gets set. usrloc README tells that xavp gets set at lookup (if
i got it right), but is also tells "The tm module parameter xavp_contact
must also be set to the same value to use the t_load_contacts and
t_next_contacts functions".
does that mean that t_load_contacts()/t_next_contacts() does not anymore
work if xavp_contact parameter is not defined for tm and usrloc modules?
…-- juha
|
|
If the usrloc parameter "xavp_contact" is set, the given XAVP is populated with the contact attributes when the "lookup" function is called. The usrloc README example uses the name 'ulattrs'. The tm module parameters 'contacts_avp' and 'contact_flows_avp' are populated when the t_load_contacts() function is called. These store the data from the branch structures but, before my changes, did not know anything about the attributes loaded by usrloc. My changes mean that the usrloc attributes are now loaded into the 'contacts_avp' data when t_load_contacts() is called. However, the tm module needs to know the name of the XAVP that usrloc stored these attributes in, hence the new parameter and why they must have the same value. If you do not set the 'xavp_contact' parameter in usrloc, then attributes are not stored / loaded when you call 'register' / 'lookup'. It is therefore not needed in tm module either. |
|
Hugh Waite writes:
The tm module parameters 'contacts_avp' and 'contact_flows_avp' are
populated when the t_load_contacts() function is called. These store
the data from the branch structures but, before my changes, did not
know anything about the attributes loaded by usrloc.
thanks for your explanation. by usrloc attributes you mean all the
fields of location table?
…-- juha
|
|
This fix regards the tag-value pairs that are stored in the 'location-attrs' table. I am adding custom values to the REGISTER transaction just before calling save() and need them to be restored per branch when calling lookup(). Hugh -----Original Message----- Hugh Waite writes:
thanks for your explanation. by usrloc attributes you mean all the fields of location table? -- juha sr-dev mailing list This e-mail and any attachment is for authorised use by the intended recipient(s) only. It may contain proprietary material, confidential information and/or be subject to legal privilege. It should not be copied, disclosed to, retained or used by, any other party. If you are not an intended recipient then please promptly delete this e-mail and any attachment and all copies and inform the sender. Thank you for understanding. |
Implement load and restore of usrloc contact attributes in the t_load_contacts, t_next_contacts and t_next_contact_flows functions in tm module.
Includes documentation of the new tm parameter 'xavp_contact'