Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kamdbctl: added verification before drop command #1858

Closed
wants to merge 4 commits into from
Closed

kamdbctl: added verification before drop command #1858

wants to merge 4 commits into from

Conversation

fredposner
Copy link
Member

  • add get_answer and warning that drop command will drop existing database

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

Added verification to drop command. Allows for someone to change their mind before dropping existing database similar to #1852

- add get_answer and warning that reinit will drop exisiting database
- even seasoned users forget and theres no backing out
- add get_answer and warning that reinit will drop exisiting database
- even seasoned users forget and theres no backing out
- add get_answer and warning that drop command will drop existing database
henningw added a commit that referenced this pull request Feb 18, 2019
…ion (GH #1858)

- warn that the drop command will drop existing DB, ask for confirmation
- manually merge pull request GH #1858 from fredposner, fred at qxork dot com
@henningw
Copy link
Contributor

Thank you. I merged it manually, as your branch still contains the previous commits related to the reinit change.

@henningw henningw closed this Feb 18, 2019
henningw added a commit that referenced this pull request Feb 18, 2019
…ion (GH #1858)

    - warn that the drop command will drop existing DB, ask for confirmation
    - manually merge pull request GH #1858 from fredposner, fred at qxork dot com
henningw added a commit that referenced this pull request Feb 18, 2019
…ion (GH #1858)

    - warn that the drop command will drop existing DB, ask for confirmation
    - manually merge pull request GH #1858 from fredposner, fred at qxork dot com
@fredposner
Copy link
Member Author

Thanks. I'll get better.

@henningw
Copy link
Contributor

@fredposner don't worry, all fine. :-)

@miconda
Copy link
Member

miconda commented Feb 18, 2019

For the records, when pushing manually a commit from a PR as it is, the initial author of the commit can be preserved via git commit --author="..." .... The author can be taken from the patch of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants