Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

siptrace: safety check for tm callback parameter #1931

Merged
merged 1 commit into from Apr 23, 2019

Conversation

ionutionita92
Copy link
Contributor

@ionutionita92 ionutionita92 commented Apr 22, 2019

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

Fix coverity found issue. Unlikely to happen but still it was a bug leading to potential crashes.

@miconda
Copy link
Member

miconda commented Apr 22, 2019

The commit message should explain what is fixed, not what tool reported the issue. So it should be something like:

siptrace: safety check for tm callback parameter

Also, the comments should not be related to discovery tool -- better do not add comments that are not relevant for understanding the code.

@ionutionita92 ionutionita92 changed the title siptrace: fix coverity found issue siptrace: safety check for tm callback parameter Apr 23, 2019
@ionutionita92
Copy link
Contributor Author

Fixed. Sorry for not complying to the rules. Won't happen again

@miconda
Copy link
Member

miconda commented Apr 23, 2019

We try to be consistent and coherent with the commit messages, that's why we point them in pull request and try to have most of them relevant for the history of development.

But if it happens again, no big worries, the message in the commit of the pull request can be changed easier than after commit is merged in master.

I am going to merge it, thanks!

@miconda miconda merged commit ff1ce23 into kamailio:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants