Add symbols "#*+" to drouting tree #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code to compute the index is repeating in 3 places. It should be made a function. You can add an addition patch to this pull request and I will merge then. In long term, the list of characters that can be used has to be made a module parameter, for proper flexibility. |
|
or you can rework the patch amend and push --force |
|
uniform code is moved to function. |
|
I am going to merge it. For the future, when writing the commit messages, use the guidelines from: |
miconda
added a commit
that referenced
this pull request
Jun 15, 2015
Add symbols "#*+" to drouting tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch drouting can use "#*+" in addition to the decimal digits.
Some tests with a set of 500.000 rules (64bit system)
Performance impact (kamcmd droating.reload):
decimal only: ~21sec
decimal and "#*+": ~21sec
Memory usage (kamcmd core.shmmem):
after start, decimal only, used: 203119976
after start, decimal and "#*+", used: 240338888