Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialplan: add reload_delta parameter #1946

Merged
merged 1 commit into from May 6, 2019
Merged

dialplan: add reload_delta parameter #1946

merged 1 commit into from May 6, 2019

Conversation

marcocapetta
Copy link
Contributor

@marcocapetta marcocapetta commented May 6, 2019

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

In commit 99d5da8 a mechanism for basic safety in case of concurent rpc reload were added. This works fine but it is limiting our test scenarios where multiple changes should happen quickly.

The new dialplan paramenter reload_delta allows everyone to configure rpc reload rate limit to the preferred number of seconds.
In case the parameter is not specified. the default value is 5 seconds.

- make the rate limit of maximum allowed dialplan reload configurable
using the new 'reload_delta' paramenter.
@linuxmaniac
Copy link
Member

I would say We should not backport this change since this is a new parameter and no new features should go to stable releases

@linuxmaniac linuxmaniac merged commit 926a97f into kamailio:master May 6, 2019
@linuxmaniac
Copy link
Member

Thanks! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants