ims_registrar_scscf: changed str r_reginfo_s format: from 'version=%s… #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' to 'version=%d'.
|
Thank you for the pull-request. Can you explain a bit the motivation for the change, is it just a refactoring or does it fix a bug? |
|
This is a bug fix.
In NOTIFY message from S-CSCF to UE, Message Body contains different xml
parameters and one of them can be a contact parameter with list of
unknown-params. In some cases unknown-param has value with '%' inside. For
instance: "urn%3Aurn-7%3A3gpp-service.ims.icsi.me". In this case, before
the fix, adding of reginfo version breaks the string of unknown-param like
this: "urn0X0P+0urn-70X0P+03gpp-service.ims.icsi.me". Adding reginfo
version before contact parameters keeps unknown-param string unchanged.
…On Mon, 20 May 2019 at 22:07, Henning Westerholt ***@***.***> wrote:
Thank you for the pull-request. Can you explain a bit the motivation for
the change, is it just a refactoring or does it fix a bug?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1961?email_source=notifications&email_token=ALKTZB6MUBLSU5AZ5LNVEJTPWLZFPA5CNFSM4HN72SCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVZZCJQ#issuecomment-494113062>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALKTZB72LCC24KBZUOSYWBTPWLZFPANCNFSM4HN72SCA>
.
--
Best Regards,
Aleksandar Yosifov
|
henningw
pushed a commit
that referenced
this pull request
May 22, 2019
… ' to 'version=%d'. (GH #1961) - changed str r_reginfo_s format: from 'version=%s ' to 'version=%d'. (GH #1961) - In NOTIFY message from S-CSCF to UE, Message Body contains different xml parameters and one of them can be a contact parameter with list of unknown-params. In some cases unknown-param has value with '%' inside. Before the fix, adding of reginfo version breaks the string of unknown-param. Adding reginfo version before contact parameters keeps unknown-param string unchanged.
|
Thank you, I merged it manually because of the not correct formatted commit log message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…' to 'version=%d'.
Pre-Submission Checklist
in
doc/subfolder, the README file is autogenerated)Type Of Change
Checklist:
Description