Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evapi:return code and log fixed for no evapi client while sending #2013

Merged

Conversation

surendratiwari3
Copy link
Contributor

@surendratiwari3 surendratiwari3 commented Jul 19, 2019

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

Right now, if there is no evapi client to send message then no logs are getting printed. This make us to not set the alert if send failed. After this changes if there is no evapi client we are going to get that in line like send_failed.

@miconda
Copy link
Member

miconda commented Jul 19, 2019

I will merge it, but then I will do some further updates:

  • print the log message as a warning, not error -- I think it is more appropriate, not being an error of processing. If you want, you can follow up with a new PR to add a modparam to set the log level for this message
  • edit a bit the message to reflect better the situation (of course, as I see it)

Thanks!

@miconda miconda merged commit 7209971 into kamailio:master Jul 19, 2019
@surendratiwari3
Copy link
Contributor Author

@miconda agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants