Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nathelper: Fixed memory leak #2062

Closed
wants to merge 1 commit into from
Closed

nathelper: Fixed memory leak #2062

wants to merge 1 commit into from

Conversation

pintulohargcetts
Copy link

  • Allocated buffer is not freed when contact fetch is failed
  • Leak frequently occurs when database disconnects and reconnects

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

Found the leak during stress test and intentionally disconnecting database access

nathelper: Fixed memory leak
411c38e 
- Allocated buffer is not freed when contact fetch is failed
- Leak frequently occur when database disconnect and reconnect
@henningw henningw self-assigned this Sep 10, 2019
@henningw
Copy link
Contributor

Thank you, good catch. Manually merged (with a small log message extension) and also backported.

@henningw henningw closed this Sep 10, 2019
henningw pushed a commit that referenced this pull request Sep 10, 2019
@henningw
nathelper: Fixed memory leak in nathelper fetch contact timer (GH #2062)
79fecc6 
- Allocated buffer is not freed when contact fetch is failed
- Leak frequently occur when database disconnect and reconnect
henningw pushed a commit that referenced this pull request Sep 10, 2019
@henningw
nathelper: Fixed memory leak in nathelper fetch contact timer (GH #2062)
79dd00c 
- Allocated buffer is not freed when contact fetch is failed
- Leak frequently occur when database disconnect and reconnect

(cherry picked from commit 79fecc6)
henningw pushed a commit that referenced this pull request Sep 10, 2019
@henningw
nathelper: Fixed memory leak in nathelper fetch contact timer (GH #2062)
ee4f8d4 
- Allocated buffer is not freed when contact fetch is failed
- Leak frequently occur when database disconnect and reconnect

(cherry picked from commit 79fecc6)
@pintulohargcetts pintulohargcetts deleted the memleak branch September 11, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@henningw henningw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pintulohargcetts @henningw