Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registrar: add path value to xavp_rcd #2162

Merged
merged 1 commit into from Dec 5, 2019

Conversation

linuxmaniac
Copy link
Member

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally

Description

Add path value to xavp_rcd. This is needed when checking if a subscriber is still registered
with a certain parameter in the path.

@henningw
Copy link
Contributor

henningw commented Dec 5, 2019

This is a small change and a good extension, I think it is fine to merge it.

@miconda
Copy link
Member

miconda commented Dec 5, 2019

I am fine to merge, but probably we should add in short term a new parameter to control what attributes are cloned in xavp, some of them can be large in size like, path with couple of hops, and maybe not needed in specific cases.

@linuxmaniac
Copy link
Member Author

@miconda something like modparam("registrar", "xavp_rcd_mask", 0) so we can define what to load?

@miconda
Copy link
Member

miconda commented Dec 5, 2019

@linuxmaniac - yes, but can be also the opposite condition: what to skip. What people find better.

@henningw
Copy link
Contributor

henningw commented Dec 5, 2019

I like "what to skip" more, in the end most people would probably use it on smaller installations.

@linuxmaniac
Copy link
Member Author

Ok, I'm going to merge and I will work on the module parameter to define what values to skip

@linuxmaniac linuxmaniac merged commit fbe6d3b into master Dec 5, 2019
@linuxmaniac linuxmaniac deleted the vseva/registrar_lookup_path branch December 5, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants