Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ims_ipsec_pcscf: fixed defects and warnings: #2163

Merged
merged 1 commit into from Dec 3, 2019

Conversation

alexyosifov
Copy link
Contributor

@alexyosifov alexyosifov commented Dec 3, 2019

  • fixed a defect reported from Coverity Scan - Concurrent data access
    violations in spi_gen.c for spi_data->spi_val.
  • in create_ipsec_tunnel() return -1 when unable to convert ip address.
  • in ipsec_create() go to cleanup instead return -1 when get request
    for reply fails. Fixed debug message for that error.

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

- fixed a defect reported from Coverity Scan - Concurrent data access
  violations in spi_gen.c for spi_data->spi_val.
- in create_ipsec_tunnel() return -1 when unable to convert ip address.
- in ipsec_create() go to cleanup instead return -1 when get request
  for reply fails. Fixed debug message for that error.
@henningw henningw merged commit 8973feb into kamailio:master Dec 3, 2019
@henningw
Copy link
Contributor

henningw commented Dec 3, 2019

Thank you, merged and backported to 5.3. Just FYI - due to the extensions done for release 5.3 it did not apply cleanly to 5.2 and 5.1.

@alexyosifov alexyosifov deleted the ims_ipsec_bug_fixes branch April 21, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants