Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userblacklist: added missing kemi functions #2190

Closed
wants to merge 5 commits into from
Closed

userblacklist: added missing kemi functions #2190

wants to merge 5 commits into from

Conversation

fsantulli
Copy link
Contributor

@fsantulli fsantulli commented Jan 6, 2020

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

  • added three new kemi functions allowing to call the missing check_blacklist (global or custom) and check_whitelist functions;
  • fixed dynamic sources loading when adding sources within the script calls;
  • fixed match_mode in check_whitelist function as it was just numeric before.

@miconda
Copy link
Member

miconda commented Jan 6, 2020

Thanks for the contribution! The commit message should be formatted according to the contributing guide:

You actually did the pull request title and comments like the commit message should have been.

This PR can be eventually merged manually with the proper commit message format, but have it in mind for future contributions.

I have also some comment to the code of the commit, otherwise maybe @henningw or @lbalaceanu would like to review before merging.

@fsantulli fsantulli closed this Jan 7, 2020
@fsantulli fsantulli reopened this Jan 7, 2020
@fsantulli fsantulli requested a review from miconda January 8, 2020 09:29
@henningw
Copy link
Contributor

No action necessary from your side. :-) I will also have a look later today and merge it when I did not notice anything else.

henningw pushed a commit that referenced this pull request Jan 13, 2020
…for check_whitelist (GH #2190)

- add KEMI functions for userblacklist module
- adapt source loading function after KEMI addition
- fix match mode for alphanumeric characters for check_whitelist function
- merged pull request GH #2190
@henningw
Copy link
Contributor

Pull request merged manually (to adapt the commit logs). This changed code in different areas , so I decided to not backport it to stable branches right now. After some testing it could be backported to 5.3 stable branch, though.

@henningw henningw closed this Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants