Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: fixed SystemD service install path #2197

Closed
wants to merge 1 commit into from
Closed

pkg: fixed SystemD service install path #2197

wants to merge 1 commit into from

Conversation

guss77
Copy link
Contributor

@guss77 guss77 commented Jan 20, 2020

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

  • systemd/system/service is not a real directory. Services should be in systemd/system to be loaded by SystemD.
  • Also, fixed typo in %files.

Services should be in `systemd/system` to be loaded by SystemD. Also, fixed typo in `%files`.
@miconda
Copy link
Member

miconda commented Jan 20, 2020

The commit message first line is not formatted according to the contributing guidelines:

You can reformat the commit message if you want, then the PR can be merged directly.

Otherwise the patch can be applied manually this time and you keep in mind for future commits.

Note also that the specs of oracle linux were not properly maintained lately, if you want to update their content for the last version, see the spec file from obs folder, that should be pretty actual.

@sergey-safarov
Copy link
Member

Oracle dist based in RHEL dist and must be packaged using this packaging files

This already documented at Oracle README.md

I prefer to delete not maintained oracle packaging files and leave only README.md file.

@sergey-safarov sergey-safarov self-assigned this Jan 20, 2020
@sergey-safarov sergey-safarov added the pkg packaging related label Jan 20, 2020
@guss77
Copy link
Contributor Author

guss77 commented Jan 20, 2020

I prefer to delete not maintained oracle packaging files and leave only README.md file.

Sounds like a valid solution - if the position of the project is that RPM builds should be based on pkg/kamailio/obs instead of any of the pkg/kamailio/oracle files, I can work with that.

I'm currently building RPMs for my use based on the oracle file, and as it has a few problems, I keep patching it locally for each release - which is getting tedious. I'll update my packaging to use the obs file and will submit patches as relevant (and I'll make sure to write comments as required, next time).

@guss77 guss77 closed this Jan 20, 2020
@guss77 guss77 deleted the patch-1 branch January 20, 2020 17:09
@sergey-safarov
Copy link
Member

You are welcome to update OBS packaging file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg packaging related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants