Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: examples; ims: Update kamailio.cfg example to function out of the box on current releases #2203

Merged
merged 2 commits into from Feb 5, 2020
Merged

misc: examples; ims: Update kamailio.cfg example to function out of the box on current releases #2203

merged 2 commits into from Feb 5, 2020

Conversation

nickvsnetworking
Copy link
Contributor

@nickvsnetworking nickvsnetworking commented Jan 25, 2020 •
edited

Changes to example files for PCSCF in misc/examples/ims to make funcitional with current stable version.

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

Changes to example files for PCSCF in misc/examples/ims to make funcitional with current stable version.

Changes:

  • Loading IPsec module prior to IMS Usrloc PCSCF (Now required)
  • removed modparam("ims_usrloc_pcscf", "hashing_type", 2) from example (This parameter was removed some time ago)
  • Fix to formatting of single MySQL connection to work in current version
  • Bind to any IP by default
  • Dispatcher parameters only loaded if required

@nickvsnetworking
misc: examples: IMS PCSCF kamailio.cfg update
74e6daa 
Minor changes to make the example functional in the current stable release and higher.

- removed modparam("ims_usrloc_pcscf", "hashing_type", 2) This parameter was removed under a466c7b
kamailio@a466c7b#diff-bd9d5dd4265257881c8e19ea24ab533f
- Dispatcher parameters only loaded if #!WITH_SBC defined
- Load IPsec IMS Module by default (IPsec module is required for IMS Usrloc to load)
@nickvsnetworking
misc: examples: IMS PCSCF pcscf.cfg update
decd184 
Minor changes to make the example functional in the current stable release and higher.

- Load WITH_IPSEC by default (IPsec module is required for IMS Usrloc to load)
- Bind to any IP in example
- Removed con=> prefix on MySQL Connection (not used in single instance / if not clustered)
@miconda
Copy link
Member

miconda commented Feb 5, 2020

Thanks!

@miconda miconda merged commit d74157a into kamailio:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickvsnetworking @miconda