Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corex: check not in SHM before PKG free for path #2237

Merged
merged 1 commit into from Mar 5, 2020

Conversation

smititelu
Copy link
Contributor

@smititelu smititelu commented Mar 3, 2020

Do the same for reset_path_vector() in core msg parser.

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

Description

Hi,

Please have a look on this old discussion: https://lists.kamailio.org/pipermail/sr-dev/2018-July/047190.html

We have been using the shm_address_in() since then and no other apparent issue found since then.

Please let me know what you think. Also let me know if I can backport this to 5.3.

Thank you,
Stefan

Do the same for reset_path_vector() in core msg parser.
@miconda
Copy link
Member

miconda commented Mar 3, 2020

Fine to merge and backport, thanks!

@smititelu smititelu merged commit 395303d into kamailio:master Mar 5, 2020
@henningw
Copy link
Contributor

henningw commented Mar 5, 2020

Thanks Stefan, if necessary please also backport to 5.2 branch.

@henningw
Copy link
Contributor

henningw commented Mar 5, 2020

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants