Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

siptrace flag fixes #2273

Merged
merged 4 commits into from Apr 6, 2020
Merged

siptrace flag fixes #2273

merged 4 commits into from Apr 6, 2020

Conversation

grumvalski
Copy link
Contributor

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

@miconda miconda changed the title Grumvalski/siptrace flag fixes siptrace flag fixes Apr 6, 2020
@miconda
Copy link
Member

miconda commented Apr 6, 2020

You can go ahead and merge it.

I am thinking that it could make sense to add some dedicated functions to the TM module and TM API to get only the needed fields from a transaction, not to have to backup active transaction, lookup the one we need for checking and then restoring to the old one, as long as we do not need to do any other operation with the searched transaction. But this only as a future enhancement (the idea popped up a while ago, for some other parts of the code, but could be used here as well).

@grumvalski
Copy link
Contributor Author

Agree that such functions could be very useful in cases like this one.
Should I backport to 5.3?

@grumvalski grumvalski merged commit 8c18640 into master Apr 6, 2020
@grumvalski grumvalski deleted the grumvalski/siptrace_flag_fixes branch April 7, 2020 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants