Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ims_registrar_scscf: fix aor generating in lookup() #2287

Closed
wants to merge 0 commits into from

Conversation

alexyosifov
Copy link
Contributor

  • If uri contains some parameters before '@' as phone context,
    till now the function strips everything after that. With the
    fix all parameters before and after '@' are stripped and
    the domain remaining.

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

@miconda
Copy link
Member

miconda commented Apr 16, 2020

Thanks for this contribution!

However, wouldn't it be better to use parse_sip_msg_uri() so _m->new_uri or _m->first_line.u.request.uri is parsed in the _m->parsed_uri field and then just build the AoR using _m->parsed_uri.user and _m->parsed_uri.host?

@alexyosifov
Copy link
Contributor Author

Thanks for this contribution!

However, wouldn't it be better to use parse_sip_msg_uri() so _m->new_uri or _m->first_line.u.request.uri is parsed in the _m->parsed_uri field and then just build the AoR using _m->parsed_uri.user and _m->parsed_uri.host?

Thanks for the suggestion. I will do the changes and test them next week.

@alexyosifov
Copy link
Contributor Author

Hi,
Could you please check it again. I did the recommended changes.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants