Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndb_redis: add sentinel support to reconnection logic #2319

Merged
merged 1 commit into from May 12, 2020

Conversation

cruzccl
Copy link
Contributor

@cruzccl cruzccl commented May 8, 2020

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

This PR replicates sentinel logic added in initial redis connection (via cc8e621) into reconnection function.

This way, in case of loosing connection with Redis, Kamailio will be able to reconnect to redis asking to sentinel servers defined in modparams.

- cc8e621 added sentinel support in initial redis connection.

- this commit replicates the logic into reconnection function.
@cruzccl cruzccl force-pushed the redis-sentinel-reconnection branch from 452ca10 to e3fbe59 Compare May 8, 2020 16:07
@miconda
Copy link
Member

miconda commented May 12, 2020

Thanks!

@miconda miconda merged commit 62e5109 into kamailio:master May 12, 2020
@cruzccl cruzccl deleted the redis-sentinel-reconnection branch May 12, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants