dispatcher: add attrs param to rpc 'add' call #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, it looks good to me. I think it can be merged. |
|
Thanks Henning. |
miconda
reviewed
May 28, 2020
|
|
||
| flags = 0; | ||
|
|
||
| if(rpc->scan(ctx, "dS*d", &group, &dest, &flags) < 2) { | ||
| if(rpc->scan(ctx, "dS*d", &group, &dest, &flags, &attrs) < 3) { |
There was a problem hiding this comment.
I think here is missing and extra S in scan's 2nd parameter.
There was a problem hiding this comment.
The above condition needs some update. Because attrs is optional, then it is still fine to go on with return code 2 (which represents the number of items/params scanned).
Probably return code has to be stored in a variable, e.g., then if ret<2 is error, if ret==2 then attrs.s=NULL and attrs.len=0 (or attrs=STR_NULL when declared).
There was a problem hiding this comment.
Right, I'm going to fix.
miconda
reviewed
May 28, 2020
| @@ -1800,15 +1800,16 @@ static void dispatcher_rpc_add(rpc_t *rpc, void *ctx) | |||
| { | |||
| int group, flags; | |||
| str dest; | |||
| str attrs; | |||
There was a problem hiding this comment.
Fix also the indentation here, since the S needs to be added below.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
in
doc/subfolder, the README file is autogenerated)Type Of Change
Checklist:
Description
Expands the rpc 'add' command allowing to specify the "attrs" body.