Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cnxcc: don't terminate non confirmed calls #2347

Merged
merged 1 commit into from Jun 4, 2020

Conversation

linuxmaniac
Copy link
Member

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

Description

  • non confirmed calls can't be terminated via dialog.terminate_dlg() API
  • set call.max_amount to 0 to terminate the call if gets confirmed

@linuxmaniac linuxmaniac changed the base branch from vseva/cnxcc to master June 4, 2020 09:10
* non confirmed calls can't be terminated via dialog.terminate_dlg() API
* set call.max_amount to 0 to terminate the call if gets confirmed

fix #2346
@linuxmaniac linuxmaniac merged commit ca0fc18 into master Jun 4, 2020
@linuxmaniac linuxmaniac deleted the vseva/cnxcc_fix_logic branch June 4, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant