Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialog: improve warning message to help better identify dialog lookup failures #2367

Merged
merged 1 commit into from Jun 24, 2020

Conversation

eschmidbauer
Copy link
Contributor

@eschmidbauer eschmidbauer commented Jun 19, 2020

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

adding the call-id will allow users to better trace when they see the warning message:
WARNING: dialog [dlg_handlers.c:1322]: dlg_onroute(): unable to find dialog...

@miconda
Copy link
Member

miconda commented Jun 24, 2020

Thanks!

@miconda miconda merged commit 92ef21d into master Jun 24, 2020
@eschmidbauer eschmidbauer deleted the dialog-improve-warning-msg branch June 24, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants