Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing build requirements #2368

Closed
wants to merge 1 commit into from
Closed

Conversation

guss77
Copy link
Contributor

@guss77 guss77 commented Jun 23, 2020

I'm building in Docker containers, and with the minimal CentOS/Fedora/whatever image you get from official repos, builds will fail without installing these.

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

I'm building in Docker containers, and with the minimal CentOS/Fedora/whatever image you get from official repos, builds will fail without installing these.
miconda added a commit that referenced this pull request Jun 23, 2020
- set packager to Sergey Safarov
- add more build requirements, including those from GH #2368
@miconda
Copy link
Member

miconda commented Jun 23, 2020

Not having the commit first line as per contributing guide, I added those build requirements as part of commit 71248a2, along with other changes.

If any issue introduced (eg., I added also pkgconfig which makes it easier to detect path to libs and include files), open an issue, or make a PR, but follow the contributing guidelines so the PR can be merged from here using the web ui:

@miconda miconda closed this Jun 23, 2020
@sergey-safarov
Copy link
Member

Hi Daniel
Think this change

%if 0%{?rhel} || 0%{?centos_ver}
%if 0%{?rhel} > 6 || 0%{?centos_ver} > 6
BuildRequires:  pkgconfig
%endif
%else
BuildRequires:  pkgconfig
%endif

Is equal to

%if 0%{?rhel}
%if 0%{?rhel} > 6
BuildRequires:  pkgconfig
%endif
%else
BuildRequires:  pkgconfig
%endif

And equal to

%if 0%{?rhel} > 6
BuildRequires:  pkgconfig
%else
BuildRequires:  pkgconfig
%endif

As pkgconfig is present in all RPM supported dists think we can use

BuildRequires:  pkgconfig

What you think?

@miconda
Copy link
Member

miconda commented Jun 24, 2020

Not having CentOS/RHEL 6 around, I googled a bit and couldn't find it for sure that they ship with pkgconfig. If yes, go ahead and remove that condition and add pkgconfig to the BuildRequires listing make, gcc, etc... Thanks!

@sergey-safarov
Copy link
Member

yes, exists

[safarov@safarov-dell kamailio-upstream]$ docker run -it centos:6
[root@c8b81ef4309e /]# pkg-config --version
0.23

I make changes

sergey-safarov added a commit that referenced this pull request Jun 24, 2020
@guss77 guss77 deleted the patch-1 branch June 25, 2020 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants