Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dipatcher: dockbook and config formatting #2375

Merged
merged 14 commits into from Jun 29, 2020

Conversation

sergey-safarov
Copy link
Member

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

I have

  • fixed DocBook validator warnings;
  • space formatting;
  • simplified route[WITHINDLG]

@miconda miconda merged commit ae828e8 into kamailio:master Jun 29, 2020
@miconda
Copy link
Member

miconda commented Jun 29, 2020

Thanks, squashed and merged, with the comment that the extra exit has the purpose of making it easier to understand that execution doesn't continue after that point, without jumping what is the the executed sub-route. The exit after exit is not having any effect. It could be just a personal preference on config readability.

@miconda
Copy link
Member

miconda commented Jun 29, 2020

Hmm, squashing here failed for what so ever reason, went out like a simple PR merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants