Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core websocket close event #2397

Merged
merged 2 commits into from Jul 16, 2020
Merged

core websocket close event #2397

merged 2 commits into from Jul 16, 2020

Conversation

lazedo
Copy link
Contributor

@lazedo lazedo commented Jul 13, 2020

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

allow kamailio modules to be notified when a websocket is closed without depending on script callbacks.
this allows for multiple independent modules to subscribe to new core event SREV_TCP_WS_CLOSE

* allows multiple consumers
* returns last result
@lazedo
Copy link
Contributor Author

lazedo commented Jul 16, 2020

@miconda any other comments or can this be merged ?

@miconda
Copy link
Member

miconda commented Jul 16, 2020

Can be merged.

@lazedo lazedo merged commit 1691478 into master Jul 16, 2020
@lazedo lazedo deleted the ws-close-event branch July 16, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants