Ims scscf notify improvements #2401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a new contact state: CONTACT_NOTIFY_READY - protect the
deletion of contact during the preparation of NOTIFY msg.
- Improved mem_timer_udomain() - protect the deletion of contact
during the preparation of NOTIFY msg.
- Improved process_impurecord() - first doing the contacts'
validity, then the subscribers' validity. This prevents contact
from remaining in the database after deleting a subscriber.
…ements
- Added a new IMS registrar event: IMS_REGISTRAR_SUBSEQUENT_SUBSCRIBE -
used to skip NOTIFY msg after receiving of subsequent subscribe msg.
- Added a new parameter in event_reg(), create_notifications() and
notify_subscribers() methods: c_passed contact - used to mainly in
create_notification().
- Changes in create_notification() - the checks for sending NOTIFY
msgs have been expanded and the new parameter c_passed is used for
that.
- Changes in subscribe_to_reg() - sending NOTIFY only for the
initial subscriptions.
- Changes in generate_reginfo_full() - the old functionality with
all contacts in NOTIFY msg has been returned based on RFC3680. Added
mechanism to change all contact states from
CONTACT_EXPIRE_PENDING_NOTIFY to CONTACT_NOTIFY_READY after reginfo
generation.
|
If nobody has comments, then I guess it can be merged. |
|
Yes, last time when I was looking the lgtm checks were not finished yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
in
doc/subfolder, the README file is autogenerated)Type Of Change
Checklist:
Description