Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add sip_parser_log core variable #2402

Merged
merged 1 commit into from Jul 21, 2020
Merged

core: add sip_parser_log core variable #2402

merged 1 commit into from Jul 21, 2020

Conversation

lazedo
Copy link
Contributor

@lazedo lazedo commented Jul 17, 2020

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

when handling non sip messages, parser errors are logged at core level which defaults to ERR.
since this may induce in error sysops or log scanners, sometimes the core level is set to debug just to omit these
messages from log, which is not good since other messages are omitted too.
this commit adds a new core variable to set the log level for message parsing errors.
this way, we can explicitly set the log level for message parsing while leaving the core level at ERR.

* when handling non sip messages, parser errors are logged at core level
which defaults to ERR. since this may induce in error sysops or log
scanners, sometimes the core level is set to debug just to omit these
messages from log, which is not good since other messages are omitted
too. this commit adds a new core variable to set the log level for
message parsing errors. this way, we can explicitly set the log level
for message parsing while leaving the core level at ERR.
@lazedo lazedo requested a review from miconda July 17, 2020 10:10
@miconda miconda merged commit 256d263 into master Jul 21, 2020
@lazedo lazedo deleted the sip-parser-log branch September 14, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants