New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
msrp: fixed IPv6 address parsing #2472
Conversation
Can you explain where the problem actually happens? Because the patch does not seem right, being in the URI parser, making host shorter (skipping [ ]), but that is not correct, and can have other side effects. If routing is not working, then the fix has to be done in the routing part, not in the SIP uri host parsing. |
The issue happens when Kamailio receive MSRP message like
Kamailio acts as MSRP relay between IPv4 and IPv6 clients. Without fix kamailio as the host part use
And try nslookup hostname
|
I removed brackets striping and make tests - also work. |
Thanks for the details. I will have to check the code and see if this patch covers it properly, somehow I am not confident in just jumping to |
- enclose ipv6 address in square brackets for msrp pv - related to #2472
Can you test with commit 1cda029, I did a different approach to be sure there is |
I made test of 9645be commit (current master), now msrp messages properly parsed and relayed via IPv6. |
Thanks! The commits can be backported. If you need them quickly, you can go ahead and backport, if not I will do it during the next days. |
Pre-Submission Checklist
in
doc/
subfolder, the README file is autogenerated)Type Of Change
Checklist:
Description
Fix relaying MSRP messages to IPv6 uri.