Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos: Remove consecutive occurrences of 'the' #2491

Merged
merged 14 commits into from Oct 2, 2020

Conversation

altmas5
Copy link
Contributor

@altmas5 altmas5 commented Oct 1, 2020

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

Remove consecutive ocurrences of 'the' across the repo

@henningw
Copy link
Contributor

henningw commented Oct 1, 2020

Thank you for the pull request. It seems that you included multiple commits to module README files. This should not be changed, please change the repective XML file in the doc directories. Please also split the commits by components, as indicated in the issue template text. Thank you.

@altmas5 altmas5 reopened this Oct 2, 2020
@altmas5
Copy link
Contributor Author

altmas5 commented Oct 2, 2020

Hi @henningw,

I rebased my branch and also did a commit for each lib/module, no README was changed (except for the main README.md).
The PR was automatically closed when I deleted the original commit to later make the individual commits and follow the issue template checklist. That's the reason for the close/re-open actions.

Regards

@henningw
Copy link
Contributor

henningw commented Oct 2, 2020

Ok, thank you. I will merge it. Please use for future pull request the proper prefix in the first line of the commit message, e.g. like "core: ..." or "carrierroute: ...", as documented in contribution docs. This helps to get a good Changelog out of the commits.

@henningw henningw merged commit 86a9e04 into kamailio:master Oct 2, 2020
@altmas5
Copy link
Contributor Author

altmas5 commented Oct 2, 2020

It's an honour to have my PR merged on kamailio.
Sorry for the commit messages format.

@altmas5 altmas5 deleted the fix-typos branch March 2, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants