Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Redefine flags as enum #2511

Merged
merged 4 commits into from Oct 20, 2020
Merged

core: Redefine flags as enum #2511

merged 4 commits into from Oct 20, 2020

Conversation

gaaf
Copy link
Contributor

@gaaf gaaf commented Oct 19, 2020

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Cleanup

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

Redefine some flags as enum instead of separate define. This makes it easier to see what flags are accepted by functions and with the right compiler flags, the compiler will warn when the wrong flags are used.

No functional changes are intended.

Easier to recognize the correct flags in the forest of flags.
Easier to recognize the correct flags in the forest of flags.
Easier to recognize the correct flags in the forest of flags.
@gaaf gaaf changed the title Fixes/flags core: Redefine flags as enum Oct 19, 2020
@henningw
Copy link
Contributor

Thank you, looks good to me. Lets wait for other people to review as well before merging it.

@miconda
Copy link
Member

miconda commented Oct 20, 2020

OK for me.

@henningw henningw merged commit ecb9fad into kamailio:master Oct 20, 2020
@henningw
Copy link
Contributor

Thanks, merged.

@gaaf gaaf deleted the fixes/flags branch October 20, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants