Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Document that a str can be zero-terminated #2520

Merged
merged 1 commit into from Oct 21, 2020
Merged

core: Document that a str can be zero-terminated #2520

merged 1 commit into from Oct 21, 2020

Conversation

gaaf
Copy link
Contributor

@gaaf gaaf commented Oct 20, 2020 •
edited

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

@gaaf
core: Document that a str can be zero-terminated
c528f70 
But by default it isn't.

The functions shm_str_dup() and pkg_str_dup() will always create a
zero-terminated copy
@gaaf gaaf mentioned this pull request Oct 20, 2020
Merged
10 tasks
@henningw
Copy link
Contributor

Great, thank you. Merged.

@henningw henningw merged commit fcdfaf9 into kamailio:master Oct 21, 2020
@gaaf gaaf deleted the upstream/core-str-zero branch October 23, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaaf @henningw