Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textops: fix append_hf function #2526

Merged
merged 1 commit into from Oct 23, 2020
Merged

textops: fix append_hf function #2526

merged 1 commit into from Oct 23, 2020

Conversation

smititelu
Copy link
Contributor

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

append after last eader occurance

Before: append_hf adds header after first header occurance

After: append_hf adds header after last header occurance
@miconda
Copy link
Member

miconda commented Oct 23, 2020

Thanks!

@miconda miconda merged commit b09a0f1 into kamailio:master Oct 23, 2020
@henningw
Copy link
Contributor

Probably the documentation should also be fixed?

https://kamailio.org/docs/modules/devel/modules/textops.html#textops.f.append_hf

"4.24. append_hf(txt[, hdr])

Appends 'txt' as header after first header field or after last 'hdr' header field. "

@miconda
Copy link
Member

miconda commented Oct 26, 2020

Pushed some notes to the docs of basic header operations functions, feel free to add more or adjust.

@henningw
Copy link
Contributor

Thank you Daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants