Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming userblacklist to userblocklist #2544

Merged
merged 5 commits into from Nov 10, 2020
Merged

Conversation

lbalaceanu
Copy link
Contributor

@lbalaceanu lbalaceanu commented Nov 9, 2020

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

PR renames userblacklist to userblocklist and makes terminology changes to blocklist, allowlist.

@miconda
Copy link
Member

miconda commented Nov 9, 2020

You can also run make dbschema to regenerate the sql/db creation scripts for kamctl and push that commit as well.

Otherwise, it is ok to merge from my point of view. Thanks!

@lbalaceanu
Copy link
Contributor Author

Thank you. Closing the PR.

@lbalaceanu lbalaceanu closed this Nov 10, 2020
@miconda
Copy link
Member

miconda commented Nov 10, 2020

You closed the PR, but didn't merge it before. Is it what you wanted?

@lbalaceanu lbalaceanu reopened this Nov 10, 2020
@lbalaceanu
Copy link
Contributor Author

:) My bad

@lbalaceanu lbalaceanu merged commit 7563a52 into kamailio:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants