Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtpengine: add CRC32 hash algo #2558

Merged
merged 1 commit into from Nov 25, 2020
Merged

rtpengine: add CRC32 hash algo #2558

merged 1 commit into from Nov 25, 2020

Conversation

smititelu
Copy link
Contributor

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

Add CRC32 selection algo.

@miconda
Copy link
Member

miconda commented Nov 25, 2020

Thanks! Looks not intrusive, maybe @rfuchs wants to check it, otherwise can be merged from my point of view.

@rfuchs rfuchs merged commit 1034908 into kamailio:master Nov 25, 2020
smititelu added a commit that referenced this pull request Nov 26, 2020
smititelu added a commit that referenced this pull request Nov 26, 2020
@smititelu
Copy link
Contributor Author

Thanks for the merge. I've backported it to 5.3 and 5.4 branches.

@henningw
Copy link
Contributor

@smititelu its a new functionality, and should therefore not backported by default to stable branches, unless it qualifies as a bugfix.
Can you provide please more information if this is indeed a bugfix? Otherwise I will revert the commit there.

@henningw
Copy link
Contributor

Like, have the existing algorithm certain problems that are fixed with the new hash algorithm.

@smititelu
Copy link
Contributor Author

Hi @henningw,

We are obtaining smoother rtpengine session distribution results using crc32. Also crc32 is an alternative for those who don't want to load crypto.so module.

So, IMHO, this PR fixes the above two.

Thank you,
Stefan

@henningw
Copy link
Contributor

Hello @smititelu, sorry this does not sound like a bug fix to me. With the same argumentation we could e.g. merge the new dispatcher algorithm 13 to stable, as it provides a better call distribution in certain scenarios. :-)
I am reverting this commits therefore in stable branches.
Please ask next time another developer before backporting some patches.

henningw added a commit that referenced this pull request Nov 27, 2020
henningw added a commit that referenced this pull request Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants