Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keepalive: fix initialization when using destination mod param #2579

Conversation

NGSegovia
Copy link
Contributor

  • Fixed the way the module is initialized, causing problems when using
    destination mod parameter because when invoking this parameter some
    utilities are not initialized (timers).

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

Description

Fixed the way the module is initialized, causing problems when using destination mod parameter because when invoking this parameter some utilities are not yet initialized (timers).

- Fixed the way the module is initialized, causing problems when using
  destination mod parameter because when invoking this parameter some
utilities are not initialized (timers).
@NGSegovia NGSegovia force-pushed the keepalive_fix_crash_on_destination_mod_param branch from 180557f to 871ae26 Compare December 16, 2020 18:24
@miconda
Copy link
Member

miconda commented Dec 17, 2020

Regarding the Coding style/C standard requirements, I started a discussion several months ago to see what people/devs consider to be better to use:

Kamailio being used in various embedded devices, with stricter compilers, in terms of declaring variables, they have to be at least at the beginning of the block, although now I also prefer at the beginning of functions, since we guide mainly after C89 (which was the implemented in compilers when project was started in 2000).

On PR, I haven't done any extensive review, but if no other comments, it can be merged.

@NGSegovia
Copy link
Contributor Author

Regarding the Coding style/C standard requirements, I started a discussion several months ago to see what people/devs consider to be better to use:

Kamailio being used in various embedded devices, with stricter compilers, in terms of declaring variables, they have to be at least at the beginning of the block, although now I also prefer at the beginning of functions, since we guide mainly after C89 (which was the implemented in compilers when project was started in 2000).

On PR, I haven't done any extensive review, but if no other comments, it can be merged.

Cristal clear, thanks for the explanation Daniel!

@NGSegovia NGSegovia merged commit 70cb87b into kamailio:master Dec 17, 2020
@NGSegovia NGSegovia deleted the keepalive_fix_crash_on_destination_mod_param branch December 17, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants