Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_async_client: add curl_follow_redirect parameter #2694

Merged
merged 1 commit into from Mar 30, 2021

Conversation

gled-rs
Copy link
Contributor

@gled-rs gled-rs commented Mar 27, 2021

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

add curl_follow_redirect module parameter to http_async_client to set CURLOPT_FOLLOWLOCATION during libcurl init, allowing libcurl to follow 3xx HTTP redirect responses.

- add curl_follow_redirect mod parameter to set CURLOPT_FOLLOWLOCATION
  to tell libcurl to follow 3xx responses.
- write the doc in doc subfolder for the curl_follow_redirect param
@grumvalski
Copy link
Contributor

Thank you! PR looks fine, documetation included. I was thinking that it would be nice to specify the parameter per query like it's done for other parameters. Could be done in this pull request or we can do it after.

@grumvalski
Copy link
Contributor

I've started working on the per query implementation. Merging this for now, before the code freeze. Thanks again!

@grumvalski grumvalski merged commit 0183de3 into kamailio:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants