Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ip parsing in ipops #2695

Closed
wants to merge 1 commit into from

Conversation

nbruning
Copy link
Contributor

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

Description

For #2645, a patch was pushed in 47b45b6, but this code does not correctly check the return value of str2ip6buf and str2ipbuf.

As described in the comments on both methods, they return zero for success.

This MR should be backported to 5.4 as well.

@miconda
Copy link
Member

miconda commented Mar 29, 2021

You have to format the commit message as per contributing guidelines:

Being small changes, I can do the fix manually this time.

miconda added a commit that referenced this pull request Mar 29, 2021
miconda added a commit that referenced this pull request Mar 29, 2021
@miconda
Copy link
Member

miconda commented Mar 29, 2021

Slightly different patch was committed and backported. Thanks!

@miconda miconda closed this Mar 29, 2021
miconda added a commit that referenced this pull request Mar 29, 2021
- reported in GH #2695

(cherry picked from commit 1d7d78c)
(cherry picked from commit 8bd9404)
NGSegovia pushed a commit to NGSegovia/kamailio that referenced this pull request Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants