Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tls] Don't use OpenSSL<1.0.2 fallback on 1.1+ #2717

Merged
merged 1 commit into from Apr 29, 2021

Conversation

space88man
Copy link
Contributor

@space88man space88man commented Apr 27, 2021

Addresses #2716. Also see https://bugs.python.org/issue29697.

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

Description

For OpenSSL 1.1.x initialization of EC SSL contexts has changed — we shouldn't be using the < 1.0.2 technique on OpenSSL 1.1+. This addresses a corner case where a TLS client(OpenSSL 1.1.1) with P-256 cert would not handshake with a TLS server with a P-521 cert. Adopted from the way that Python _ssl.c does initialization. Python, in turn, took this from Apache's mod_ssl.

@miconda
Copy link
Member

miconda commented Apr 29, 2021

Thanks!

@miconda miconda merged commit 2790453 into kamailio:master Apr 29, 2021
@space88man space88man deleted the f-openssl1.1.1 branch May 4, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants