Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ims_ipsec_pcscf: more algorithms, SA improvements #2731

Merged
merged 3 commits into from May 24, 2021

Conversation

riccardv
Copy link
Contributor

@riccardv riccardv commented May 9, 2021

  • add aes-cbc, des-ede3-cbc ipsec encryption algoriyhms
  • improve nlmsg_seq choice for concurrent multi UEs Registrations at
    same time
  • before sending replies over IPsec check the existing
    of opened TCP sockets

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

- add aes-cbc, des-ede3-cbc ipsec encryption algoriyhms
- improve nlmsg_seq choice for concurrent multi UEs Registrations at
  same time
- before sending replies over IPsec check the existing
  of opened TCP sockets
@miconda
Copy link
Member

miconda commented May 10, 2021

@alexyosifov - given that you contributed recently to this module, do you have any comment on this PR?

Copy link
Contributor

@henningw henningw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, i have added one comment regarding the time handling. Are there module any documentation updates necessary as well?

src/modules/ims_ipsec_pcscf/ipsec.c Show resolved Hide resolved
src/modules/ims_ipsec_pcscf/cmd.c Show resolved Hide resolved
src/modules/ims_ipsec_pcscf/ipsec.c Show resolved Hide resolved
@miconda
Copy link
Member

miconda commented May 19, 2021

@riccardv - I added ksr_clock_gettime() in the core/ut.h, which is portable version of clock_gettime() that works for MacOS as well. Push another commit to this PR to use it.

Any other comments from devs for this PR?

@riccardv
Copy link
Contributor Author

Thanks @miconda , I did the correction and pushed

@alexyosifov
Copy link
Contributor

@miconda , No comments from my side.

@henningw henningw merged commit de09068 into kamailio:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants