Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: enabled compilation with debug symbols by default #2811

Closed
wants to merge 1 commit into from

Conversation

sergey-safarov
Copy link
Member

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

closes GH #2789

@henningw
Copy link
Contributor

henningw commented Aug 1, 2021

Thanks for the pull request. If i am not mistake, it should be already enabled by default:

henning@app01:~/repositories/kamailio$ make Q=0
make -C src/
make[1]: Entering directory '/home/henning/repositories/kamailio/src'
Makefile.defs defs skipped
generating core/autover.h ...
saving modules list...
Makefile.defs defs skipped
gcc -g -funroll-loops -Wcast-align -m64 -minline-all-stringops -falign-loops -ftree-vectorize -fno-strict-overflow -mtune=generic -pthread -DKSR_PTHREAD_MUTEX_SHARED -Wall -DNAME='"kamailio"' -DVERSION='"5.6.0-dev0"' -DARCH='"x86_64"' -DOS='linux_' -DOS_QUOTED='"linux"' -DCOMPILER='"gcc 9.3.0"' -D__CPU_x86_64 -D__OS_linux -DVERSIONVAL=5006000 -DCFG_DIR='"/usr/local/etc/kamailio/"' -DSHARE_DIR='"/usr/local/share/kamailio/"' -DRUN_DIR='"/var/run/kamailio/"' -DPKG_MALLOC -DSHM_MMAP -DDNS_IP_HACK -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE -DHAVE_RESOLV_RES -DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLOCKLIST -DUSE_NAPTR -DWITH_XAVP -DMEM_JOIN_FREE -DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC -DDBG_SR_MEMORY -DUSE_TLS -DTLS_HOOKS -DUSE_CORE_STATS -DSTATISTICS -DMALLOC_STATS -DUSE_SCTP -DFAST_LOCK -DADAPTIVE_WAIT -DADAPTIVE_WAIT_LOOPS=1024 -DCC_GCC_LIKE_ASM -DHAVE_GETHOSTBYNAME2 -DHAVE_UNION_SEMUN -DHAVE_SCHED_YIELD -DHAVE_MSG_NOSIGNAL -DHAVE_MSGHDR_MSG_CONTROL -DHAVE_ALLOCA_H -DHAVE_TIMEGM -DHAVE_SCHED_SETSCHEDULER -DHAVE_IP_MREQN -DUSE_RAW_SOCKS -DHAVE_EPOLL -DHAVE_SIGIO_RT -DSIGINFO64_WORKARROUND -DUSE_FUTEX -DHAVE_SELECT -DMODS_DIR='"/usr/local/lib64/kamailio/modules"' -c main.c -o main.o -MMD -MP

@henningw
Copy link
Contributor

henningw commented Aug 1, 2021

Ok, your patch add is for other architectures that do not have it yet, understood.

@henningw
Copy link
Contributor

henningw commented Aug 1, 2021

For default architecture there is no change compilation output, looks good. I will push it with a small adjustment (remove some white-space changes).

henningw pushed a commit that referenced this pull request Aug 1, 2021
…hitectures

- enables compilation with debug symbols by default for other architectures in core
- pull request GH #2811
- closes GH #2789
@henningw henningw closed this Aug 1, 2021
@sergey-safarov sergey-safarov deleted the GH2789 branch August 1, 2021 21:04
miconda pushed a commit that referenced this pull request Aug 20, 2021
…hitectures

- enables compilation with debug symbols by default for other architectures in core
- pull request GH #2811
- closes GH #2789

(cherry picked from commit ed46ada)
NGSegovia pushed a commit to NGSegovia/kamailio that referenced this pull request Aug 26, 2021
…hitectures

- enables compilation with debug symbols by default for other architectures in core
- pull request GH kamailio#2811
- closes GH kamailio#2789
miconda pushed a commit that referenced this pull request Sep 17, 2021
…hitectures

- enables compilation with debug symbols by default for other architectures in core
- pull request GH #2811
- closes GH #2789

(cherry picked from commit ed46ada)
(cherry picked from commit ba8a06d)
henningw pushed a commit that referenced this pull request Oct 22, 2021
…hitectures

- enables compilation with debug symbols by default for other architectures in core
- pull request GH #2811
- closes GH #2789

(cherry picked from commit ed46ada)
(cherry picked from commit ba8a06d)
(cherry picked from commit 6981953)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants