Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usrloc: really do the ignore location record if it's a non-local socket #306

Merged
merged 2 commits into from Aug 27, 2015

Conversation

zxcpoiu
Copy link
Contributor

@zxcpoiu zxcpoiu commented Aug 27, 2015

  • When usrloc loading location records from database, and if the socket of the record is not matched in kamailio's listening socket list, It only throws LM_ERR ignoring message only but still store into memory.
    should return 0 as well.
  • And the message typo sometimes confused people to distinguish that kamailio is "sipping" the record (redirct) or "skipping" the record.

@miconda
Copy link
Member

miconda commented Aug 27, 2015

For the first patch -- the behaviour is like that on purpose, because one can have replicated location records via database and the case can be that register was processed by one server and records are loaded by another server, there being different IPs for each servers. Another situation is changing the ip address and restarting kamailio. If there is no NAT involved, the location records work fine when that socket field is ignored.

If you want to restrict this behaviour and not allow loading those records, then add a module parameter to control it.

@zxcpoiu
Copy link
Contributor Author

zxcpoiu commented Aug 27, 2015

thanks, I see.

- doing "skip" action instead "sip" action
- If set, kamailio will skip record if socket value doesn't in
  listening socket list when loading record from database.
@zxcpoiu
Copy link
Contributor Author

zxcpoiu commented Aug 27, 2015

I added it as a module parameter.

@miconda
Copy link
Member

miconda commented Aug 27, 2015

Thanks, it will be merged.

miconda added a commit that referenced this pull request Aug 27, 2015
usrloc: really do the ignore location record if it's a non-local socket
@miconda miconda merged commit cba555e into kamailio:master Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants