New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ims_qos: rx_aar - unreference dialog in case of aar update #3104
Conversation
- release the dialog reference even for aar updates as the dialog was already referenced when issuing the aar request
If we have multiple Rx_AAR in the script (e.g. for 183, then for UPDATEs) since the second AAR is considered an update, without that patch, the dialog is not unreferenced. That leads to dialog not being deleted since there is a dangling reference which leads to memory leak. |
I confirm the PR broke the dialog as commented by @atanas-wg2 |
The commit message has to start with the component name, not with the file name, respectively ims_qos in this case. @alexyosifov: is it something that you can check if it is ok? |
@atanas-wg2 @miconda Because of the following warning during compilation: |
ops sorry. @alexyosifov seems that include was missing: |
- release the dialog reference even for aar updates as the dialog was already referenced when issuing the aar request Co-authored-by: Atanas Bakalov <atanas@wgtwo.com> (cherry picked from commit ab8cb43)
- release the dialog reference even for aar updates as the dialog was already referenced when issuing the aar request Co-authored-by: Atanas Bakalov <atanas@wgtwo.com> (cherry picked from commit ab8cb43)
- release the dialog reference even for aar updates as the dialog was already referenced when issuing the aar request Co-authored-by: Atanas Bakalov <atanas@wgtwo.com> (cherry picked from commit ab8cb43)
- release the dialog reference even for aar updates as the dialog was already referenced when issuing the aar request Co-authored-by: Atanas Bakalov <atanas@wgtwo.com> (cherry picked from commit ab8cb43)
already referenced when issuing the aar request