Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ims_qos: rx_aar - unreference dialog in case of aar update #3104

Merged
merged 1 commit into from May 30, 2022

Conversation

atanasdb
Copy link
Contributor

  • release the dialog reference even for aar updates as the dialog was
    already referenced when issuing the aar request

- release the dialog reference even for aar updates as the dialog was
  already referenced when issuing the aar request
@atanas-wg2
Copy link
Contributor

If we have multiple Rx_AAR in the script (e.g. for 183, then for UPDATEs) since the second AAR is considered an update, without that patch, the dialog is not unreferenced. That leads to dialog not being deleted since there is a dangling reference which leads to memory leak.

@riccardv
Copy link
Contributor

I confirm the PR broke the dialog as commented by @atanas-wg2

@miconda
Copy link
Member

miconda commented May 24, 2022

The commit message has to start with the component name, not with the file name, respectively ims_qos in this case.

@alexyosifov: is it something that you can check if it is ok?

@miconda miconda changed the title rx_aar: unreference dialog in case of aar update ims_qos: rx_aar - unreference dialog in case of aar update May 24, 2022
@miconda miconda merged commit ab8cb43 into kamailio:master May 30, 2022
@alexyosifov
Copy link
Contributor

@atanas-wg2 @miconda
I have checked locally the changes. The P-CSCF doesn't start correctly if trying to load the ims_qos module:
0(15988) DEBUG: <core> [core/sr_module.c:563]: load_module(): trying to load </usr/local/lib64/kamailio/modules/ims_qos.so>
0(15988) ERROR: <core> [core/sr_module.c:570]: load_module(): could not open module </usr/local/lib64/kamailio/modules/ims_qos.so>: /usr/local/lib64/kamailio/modules/ims_qos.so: undefined symbol: unref_dlg
0(15988) CRITICAL: <core> [core/cfg.y:3796]: yyerror_at(): parse error in config file /etc/kamailio_pcscf/kamailio.cfg, line 239, column 12-20: failed to load module

Because of the following warning during compilation:
Warning: rx_aar.c:184:13: warning: implicit declaration of function 'unref_dlg'; did you mean 'unref_cell'? [-Wimplicit-function-declaration] 184 | unref_dlg(data->dlg, 1); | ^~~~~~~~~

@atanas-wg2
Copy link
Contributor

ops sorry. @alexyosifov seems that include was missing:
#3127

atanasdb added a commit to atanasdb/kamailio that referenced this pull request Sep 18, 2022
- release the dialog reference even for aar updates as the dialog was
  already referenced when issuing the aar request

Co-authored-by: Atanas Bakalov <atanas@wgtwo.com>
(cherry picked from commit ab8cb43)
atanasdb added a commit to atanasdb/kamailio that referenced this pull request Sep 18, 2022
- release the dialog reference even for aar updates as the dialog was
  already referenced when issuing the aar request

Co-authored-by: Atanas Bakalov <atanas@wgtwo.com>
(cherry picked from commit ab8cb43)
miconda pushed a commit that referenced this pull request Sep 19, 2022
- release the dialog reference even for aar updates as the dialog was
  already referenced when issuing the aar request

Co-authored-by: Atanas Bakalov <atanas@wgtwo.com>
(cherry picked from commit ab8cb43)
miconda pushed a commit that referenced this pull request Sep 19, 2022
- release the dialog reference even for aar updates as the dialog was
  already referenced when issuing the aar request

Co-authored-by: Atanas Bakalov <atanas@wgtwo.com>
(cherry picked from commit ab8cb43)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants