acc: Fix reason code for locally generated replies. #3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use heap memory for the reason code instead of the stack memory. - See issue kamailio#2981
linuxmaniac
reviewed
Jun 7, 2022
src/modules/acc/acc_logic.c
Outdated
| @@ -93,15 +93,18 @@ void env_set_totag(struct cell *t, struct sip_msg *reply) | |||
| tmb.t_get_reply_totag(t->uas.request, &acc_env.to_tag); | |||
| } | |||
|
|
|||
| int env_set_reason(struct sip_msg *reply, str *buff) { | |||
| int env_set_reason(struct sip_msg *reply, str *buff, int code) { | |||
| /* | |||
There was a problem hiding this comment.
please don't comment code, just remove it
|
Indeed, the code that is no longer needed must be removed, otherwise it makes it hard to understand the changes done the patch and in long term the code will become a mess. Comments should be used only to explain the code, if one wants to check a previous version, git history is the right way. |
- Code was commented out in the previous pull request. (kamailio#3137). - This has now been corrected.
|
Thanks! |
miconda
pushed a commit
that referenced
this pull request
Jun 24, 2022
* acc: Fix reason code for locally generated replies. - Use heap memory for the reason code instead of the stack memory. - See issue #2981 * acc: Remove code which was commented out. - Code was commented out in the previous pull request. (#3137). - This has now been corrected. (cherry picked from commit e74cb23)
henningw
pushed a commit
that referenced
this pull request
Nov 28, 2022
* acc: Fix reason code for locally generated replies. - Use heap memory for the reason code instead of the stack memory. - See issue #2981 * acc: Remove code which was commented out. - Code was commented out in the previous pull request. (#3137). - This has now been corrected. (cherry picked from commit e74cb23)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
in
doc/subfolder, the README file is autogenerated)Type Of Change
Checklist:
Description