Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pua dialoginfo: improvements #3143

Merged
merged 3 commits into from Jun 16, 2022
Merged

pua dialoginfo: improvements #3143

merged 3 commits into from Jun 16, 2022

Conversation

linuxmaniac
Copy link
Member

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally

Description

Changes from Sipwise flavor:

  • refresh_pubruri_avps_flag: if enabled, this message flag indicates whether to refresh R-Uri from avps before sending the PUBLISH requests.
  • improvement for use_pubruri_avps: use locking to avoid crashes since we are using shared memory
  • local_identity_dlg_var: reporting dialog-information will use the value of the dialog variable if exists

@miconda
Copy link
Member

miconda commented Jun 16, 2022

Fine to merge from my point of view!

Just a note that there might be some design issue with dialog vars, considering some reports on the tracker, but this has to be analyzed separately, not being something specific to PR, but impacts it.

@linuxmaniac linuxmaniac merged commit 8ac3137 into master Jun 16, 2022
@linuxmaniac linuxmaniac deleted the vseva/pua_dialoginfo branch November 7, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants