pv: add monotonic clock to TimeVal pseudovariable #3191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds $TV(Sm) pseudovariable which returns the system monotonic clock as a string - on Linux, tries to use CLOCK_MONOTONIC_RAW which does not suffer from ntp time adjustement
|
Thanks for the pull-request. Could you also please add the documentation for the new PV in our wiki? Then it could be probably merged, if no other comments come in. |
|
Ok,
I'm on vacation right now, will do by the end of August.
Il mer 10 ago 2022, 11:28 Henning Westerholt ***@***.***> ha
scritto:
… Thanks for the pull-request. Could you also please add the documentation
for the new PV in our wiki
<https://github.com/kamailio/kamailio-wiki/blob/main/docs/cookbooks/devel/pseudovariables.md>?
Then it could be probably merged, if no other comments come in.
—
Reply to this email directly, view it on GitHub
<#3191 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABQKXNKJFTJPMOSL6775YLVYNY3NANCNFSM54AJPSAA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Done in kamailio/kamailio-wiki#14 |
|
Thanks, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
in
doc/subfolder, the README file is autogenerated)Type Of Change
Checklist:
Description
Sometime is helpful to have a monotonic timer to attach to events in order to discard out-of-order ones on receiving side. Current time values are not ideal since are subject to clock skews, adjustment and so on. Since we have system monotonic clock we can use that value to have a monotonic counter.
To be 100% fair CLOCK_MONOTONIC can still be skewed only by ntp adjustment, that's why we try to use CLOCK_MONOTONIC_RAW which is linux-only (afaik) that do not suffer from such adjustments.
The new pseudovariable is
$TV(Sm), which returns the monotonic counter as a string. Note that even if is based on clock, it starts from an unspecified point in time, so should really be treated as an always increasing counter.