Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uac.reg_add realm and socket support for RPC command #3198

Merged
merged 1 commit into from Aug 8, 2022

Conversation

sznoname
Copy link
Contributor

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

@henningw henningw changed the title uac.reg_add uac.reg_add realm support for RPC command Jul 25, 2022
@henningw henningw changed the title uac.reg_add realm support for RPC command uac.reg_add realm and socket support for RPC command Jul 25, 2022
@sznoname sznoname closed this Jul 28, 2022
@henningw
Copy link
Contributor

@sznoname I see you closed the PR - do you like to re-work it, or was it not complete yet?

@sznoname sznoname reopened this Jul 29, 2022
@henningw henningw merged commit a900fef into kamailio:master Aug 8, 2022
@henningw
Copy link
Contributor

henningw commented Aug 8, 2022

Thank you, merged. Small remark, please use the proper format for the commit message for eventual future pull requests, the module should be used as a prefix. Example:

uac: reg_add realm and socket support for RPC command

@hance2010
Copy link

Thanks!

@sznoname sznoname deleted the uac.rpc_uac_reg_add branch August 9, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants