rtpengine module added receive-from option to flags to managing rtpengine by a kamailio node behind dispatcher

[toharish]

Add receive-from option to flags
receive-from=1.2.3.4
required for managing rtpengine by a kamailio node behind a dispatcher
kamailio node

UE behind NAT ------>Dispatcher Kamailio-----> Location & Media management Kamailio ------> C5 SoftSwitch
                            |                                   |
                            |                                   V 
                            |                               RTPENGINE
                            |
                            |------------>Location & Media management Kamailio ----------> C5 SoftSwitch
                                                               |
                                                               V
                                                           RTPENGINE

In this scenario when the Kamailio behind the Dispatcher will be getting the $Ri as dispatcher IP and by default that will be passed to RTP Engine for NAT negotiation which will fail.
In this pull merge requst, RTP engine module a new flag is added receive-from=IP which is supposed to be the received IP from the First node through P-Accessnetwork-Info header or the contact recived tag etc..

Pre-Submission Checklist

• Commit message has the format required by CONTRIBUTING guide
• Commits are split per component (core, individual modules, libs, utils, ...)
• Each component has a single commit (if not, squash them into one commit)
• No commits to README files for modules (changes must be done to docbook files
  in doc/ subfolder, the README file is autogenerated)

Type Of Change

• Small bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new functionality)
• Breaking change (fix or feature that would change existing functionality)

Checklist:

• PR should be backported to stable branches
• Tested changes locally
• Related to issue #XXXX (replace XXXX with an open issue number)

Description

[miconda]

@toharish: you have to format the commit message as per contributing guidelines:

• https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#commit-message-format

This PR can be merged manually, but for future, use the appropriate format to make it easy to merge.

@rfuchs: any comment from your side on the patch?

[toharish]

but for future, use the appropriate format to make it easy to merge.
Thank you in the future, I will take care. I was not aware of this as it is my first merge request.

[rfuchs]

Hi,

From looking at the code, I'm not sure this is correct? In case of received-from= given in the list of flags, I see ng_flags->received_from being referenced and treated as a list (items added to it) before it's set to anything. I would expect to see something like ng_flags->received_from = bencode_list() somewhere.

[toharish]

Hi,

From looking at the code, I'm not sure this is correct? In case of received-from= given in the list of flags, I see ng_flags->received_from being referenced and treated as a list (items added to it) before it's set to anything. I would expect to see something like ng_flags->received_from = bencode_list() somewhere.

ng_flags-> recive_flags is set in the funtion
static int parse_flags(struct ng_flags_parse *ng_flags, struct sip_msg *msg, enum rtpe_operation *op,
const char *flags_str)

in line number 2279 as

                  if (str_key_val_prefix(&key, "received-from", &val, &s)) {
		ip_af = get_ip_type(s.s);
		if (ip_af == AF_INET)
		{
			s1.s="IP4";
			s1.len=3;
			bencode_list_add_str(ng_flags->received_from, &s1);
			bencode_list_add_str(ng_flags->received_from, &s);
		
		}else if (ip_af == AF_INET6)
		{
			s1.s="IP6";
			s1.len=3;
			bencode_list_add_str(ng_flags->received_from, &s1);
			bencode_list_add_str(ng_flags->received_from, &s);
		
		}
		
		
		goto next;
	}

[toharish]

Hi,

From looking at the code, I'm not sure this is correct? In case of received-from= given in the list of flags, I see ng_flags->received_from being referenced and treated as a list (items added to it) before it's set to anything. I would expect to see something like ng_flags->received_from = bencode_list() somewhere.

Thank you I have fixed it by adding
ng_flags.received-from = bencode_list(bencbuf);
at line number 2554

[rfuchs]

Typo here (dash instead of underscore). Maybe at least try to compile it before submitting?

[rfuchs]

Just a suggestion, but you could reuse ng_flags.received_from here instead of creating a new list item. But up to you.

[toharish]

Reuse of ng_flags.received_from done
fixed ng_flags.received-from = bencode_list(bencbuf); to ng_flags.received_from = bencode_list(bencbuf);
complied and verified. Thank you for your support.

[rfuchs]

LGTM now. @miconda I can squash and merge this if you want.

[miconda]

@rfuchs: ok, go ahead!

And thanks for looking into it!