Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/kamctl: allow the definition of a specific startup file at star… #3387

Conversation

bundasmanu
Copy link
Contributor

@bundasmanu bundasmanu commented Mar 3, 2023

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

Added the possibility to specify an alternative file different from the default: kamailio.cfg, when starting kamailio, using the kamctl tool.
This makes it possible to start kamailio by passing a startup file located in a specific folder (via ETCDIR env variable) and with a specific name, instead of using the default name: kamailio.cfg.

Several local tests have been performed and it has been verified that it is now possible to perform the basic start/stop/restart operations of kamailio via kamctl, considering the use of a startup file other than the default: kamailio.cfg.

Example of .kamctlrc used:

ETCDIR="/etc/my-component/confs"
RPCFIFOPATH="/run/my-component/my-component_rpc.fifo"
PID_FILE="/run/my-component/my-component.pid"
STARTUP_CONFIG_FILE="starter.cfg"
STARTOPTIONS="-m 512 -M 64 -u user -g group"

Tested on CentOS Linux release 7.9.2009 (Core).

I think this change will be interesting for many users.

Thanks

…t process

- Added the possibility to specify an alternative file different from the default: kamailio.cfg, when starting kamailio, using the kamctl tool.
This makes it possible to start kamailio by passing a startup file located in a specific folder (via ETCDIR env variable) and with a specific name, instead of using the default name: kamailio.cfg.
@dilyanpalauzov
Copy link
Contributor

If this can be managed over an environment variable, then the latter shall include all the directories. As far as I see with this change, the file must still be in /etc (or $ETCDIR, but I assume both are almost thr same).

@bundasmanu
Copy link
Contributor Author

No, with this change we can use any directory and any startup config filename to manage kamailio via kamctl. ETCDIR in the example provided uses /etc, but we can use any directory to accomplish that.

@miconda
Copy link
Member

miconda commented Mar 10, 2023

Thanks!

@miconda miconda merged commit e3b8b76 into kamailio:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants