Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool: port the route_graph.py script to python version 3.x #3480

Conversation

VoIPNuggets-com
Copy link
Contributor

@VoIPNuggets-com VoIPNuggets-com commented Jun 10, 2023

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

max_depth = int(sys.argv[2])
cfg = file(sys.argv[1], "r")
max_depth = int(sys.argv[2])
cfg = open(sys.argv[1], "r")

Check warning

Code scanning / CodeQL

File is not always closed Warning

File is opened but is not closed.
@henningw henningw merged commit fa2a69e into kamailio:master Jun 12, 2023
8 checks passed
@henningw
Copy link
Contributor

Thank you, merged. About the one warning related to the not closing file, its of course harmless, but will have a quick look.

@VoIPNuggets-com VoIPNuggets-com deleted the port-route_graph-script-to-python-version-3.x branch October 17, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants